428f1333ac
* refactor(session): store user ID in session instead of full struct
Replaces storing the full User object in the session cookie with just
the user ID. GetLoginUser now re-fetches the user from the database on
every request so credential/permission changes take effect immediately
without requiring a re-login. Includes a backward-compatible migration
path for existing sessions that still carry the old struct payload.
* feat(auth): block panel with default admin/admin credentials and guide credential change
checkLogin middleware now detects default admin/admin credentials and
redirects every panel route to /panel/settings until they are changed.
The settings page auto-opens the Authentication tab, shows a
non-dismissible error banner, and lists 'Default credentials' first in
the security checklist. Login response includes mustChangeCredentials
so the login page can redirect directly. Logout is now POST-only.
Password must be at least 10 characters and cannot be admin/admin.
* feat(settings): redact secrets in AllSettingView and add TrustedProxyCIDRs
Introduces AllSettingView which strips tgBotToken, twoFactorToken,
ldapPassword, apiToken and warp/nord secrets before sending them to
the browser, replacing them with boolean hasFoo presence flags. A new
/panel/setting/secret endpoint allows updating individual secrets by
key. Secrets that arrive blank on a save are preserved from the DB
rather than overwritten. Adds TrustedProxyCIDRs as a configurable
setting (defaults to localhost CIDRs). URL fields are validated before
save.
* fix(security): SSRF prevention, trusted-proxy header gating, CSP nonce, HTTP timeouts
Adds SanitizeHTTPURL / SanitizePublicHTTPURL to reject private-range
and loopback targets before any outbound HTTP request (node probe,
xray download, outbound test, external traffic inform, tgbot API
server, panel updater). Forwarded headers (X-Real-IP, X-Forwarded-For,
X-Forwarded-Host) are now only trusted when the direct connection
arrives from a CIDR in TrustedProxyCIDRs. CSP policy is tightened with
a per-request nonce. HTTP server gains read/write/idle timeouts. Panel
updater downloads the script to a temp file instead of piping curl into
shell. Xray archive download adds a size cap and response-code check.
backuptotgbot is changed from GET to POST.
* feat(nodes): add allow-private-address toggle per node
Adds AllowPrivateAddress to the Node model (DB default false). When
enabled it bypasses the SSRF private-range check for that node's probe
URL, allowing nodes hosted on RFC-1918 or loopback addresses (e.g.
a private VPN or LAN setup).
* chore: frontend UX improvements, CI pipeline, and dev tooling
- AppSidebar: logout via POST /logout instead of navigating to GET
- InboundList: persist filter state (search, protocol, node) to
localStorage across page reloads; add protocol and node filter dropdowns
- IndexPage: add health status strip (Xray, CPU, Memory, Update) with
quick-action buttons
- dependabot: weekly go mod and npm update schedule
- ci.yml: add GitHub Actions workflow for build and vet
- .nvmrc: pin Node 22 for local development
- frontend: bump package.json and package-lock.json
- SubPage, DnsPresetsModal, api-docs: minor fixes
* fix(ci): stub web/dist before go list to satisfy go:embed at compile time
* chore(ui): remove health-strip bar from dashboard top
* Revert "feat(auth): block panel with default admin/admin credentials and guide credential change"
This reverts commit 56ce6073ce09f08147f989858e0e88b3a4359546.
* fix(auth): make logout POST+CSRF and propagate session loss to other tabs
- Switch /logout from GET to POST with CSRFMiddleware so it matches the
SPA's existing HttpUtil.post('/logout') call (previously 404'd silently)
and blocks GET-based logout via image tags or link prefetchers. Handler
now returns JSON; the SPA already navigates client-side.
- Return 401 (instead of 404) from /panel/api/* when the caller is a
browser XHR (X-Requested-With: XMLHttpRequest) so the axios interceptor
redirects to the login page on logout-in-another-tab, cookie expiry,
and server restart. Anonymous callers still get 404 to keep endpoints
hidden from casual scanners.
- One-shot the 401 redirect in axios-init.js and hang the rejected
promise so queued polls don't stack reloads or surface error toasts
while the browser is navigating away.
- Add the CSP nonce to the runtime-injected <script> in dist.go so the
panel loads under the existing script-src 'nonce-...' policy.
- Update api-docs endpoints.js: GET /logout doc entry was missing.
* fix(settings): POST /logout after credential change
* fix(auth): invalidate other sessions when credentials change
When the admin changes username/password from one machine, sessions
on every other machine kept working until they manually logged out
because session storage is a signed client-side cookie — there is
no server-side session list to revoke.
Add a per-user LoginEpoch counter stamped into the session at login
and re-verified on every authenticated request. UpdateUser and
UpdateFirstUser bump the epoch (UpdateUser via gorm.Expr so a single
update statement is atomic), so any cookie issued before the change
no longer matches the user's current epoch and GetLoginUser returns
nil — the SPA's 401 interceptor then redirects to the login page.
Backward compatible: the column defaults to 0 and missing cookie
values are treated as 0, so sessions issued before this change
remain valid until the first credential update.
---------
Co-authored-by: Sanaei <ho3ein.sanaei@gmail.com>
250 lines
6.4 KiB
Go
250 lines
6.4 KiB
Go
package service
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"runtime"
|
|
"strconv"
|
|
"strings"
|
|
"syscall"
|
|
"time"
|
|
|
|
"github.com/mhsanaei/3x-ui/v3/config"
|
|
"github.com/mhsanaei/3x-ui/v3/logger"
|
|
)
|
|
|
|
// PanelService provides business logic for panel management operations.
|
|
// It handles panel restart, updates, and system-level panel controls.
|
|
type PanelService struct{}
|
|
|
|
// PanelUpdateInfo contains the current and latest available panel versions.
|
|
type PanelUpdateInfo struct {
|
|
CurrentVersion string `json:"currentVersion"`
|
|
LatestVersion string `json:"latestVersion"`
|
|
UpdateAvailable bool `json:"updateAvailable"`
|
|
}
|
|
|
|
const (
|
|
panelUpdaterURL = "https://raw.githubusercontent.com/MHSanaei/3x-ui/main/update.sh"
|
|
maxPanelUpdaterBytes = 2 << 20
|
|
)
|
|
|
|
func (s *PanelService) RestartPanel(delay time.Duration) error {
|
|
p, err := os.FindProcess(syscall.Getpid())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
go func() {
|
|
time.Sleep(delay)
|
|
err := p.Signal(syscall.SIGHUP)
|
|
if err != nil {
|
|
logger.Error("failed to send SIGHUP signal:", err)
|
|
}
|
|
}()
|
|
return nil
|
|
}
|
|
|
|
// GetUpdateInfo checks GitHub for the latest 3x-ui release.
|
|
func (s *PanelService) GetUpdateInfo() (*PanelUpdateInfo, error) {
|
|
latest, err := fetchLatestPanelVersion()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
current := config.GetVersion()
|
|
return &PanelUpdateInfo{
|
|
CurrentVersion: current,
|
|
LatestVersion: latest,
|
|
UpdateAvailable: isNewerVersion(latest, current),
|
|
}, nil
|
|
}
|
|
|
|
// StartUpdate starts the official updater outside of the current web request.
|
|
func (s *PanelService) StartUpdate() error {
|
|
if runtime.GOOS != "linux" {
|
|
return fmt.Errorf("panel web update is supported only on Linux installations")
|
|
}
|
|
|
|
bash, err := exec.LookPath("bash")
|
|
if err != nil {
|
|
return fmt.Errorf("bash is required to run the panel updater: %w", err)
|
|
}
|
|
|
|
scriptPath, err := downloadPanelUpdater()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
mainFolder, serviceFolder := resolveUpdateFolders()
|
|
updateScript := fmt.Sprintf("set -e; trap 'rm -f %s' EXIT; %s %s", shellQuote(scriptPath), shellQuote(bash), shellQuote(scriptPath))
|
|
|
|
if systemdRun, err := exec.LookPath("systemd-run"); err == nil {
|
|
unitName := fmt.Sprintf("x-ui-web-update-%d", time.Now().Unix())
|
|
cmd := exec.Command(systemdRun,
|
|
"--unit", unitName,
|
|
"--setenv", "XUI_MAIN_FOLDER="+mainFolder,
|
|
"--setenv", "XUI_SERVICE="+serviceFolder,
|
|
bash, "-lc", updateScript,
|
|
)
|
|
out, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
output := strings.TrimSpace(string(out))
|
|
if !strings.Contains(output, "System has not been booted with systemd") &&
|
|
!strings.Contains(output, "Failed to connect to bus") {
|
|
_ = os.Remove(scriptPath)
|
|
return fmt.Errorf("failed to start panel update job: %w: %s", err, output)
|
|
}
|
|
logger.Warning("systemd-run is unavailable, falling back to detached update process:", output)
|
|
} else {
|
|
logger.Infof("started panel update job via systemd-run unit %s", unitName)
|
|
return nil
|
|
}
|
|
}
|
|
|
|
cmd := exec.Command(bash, "-lc", updateScript)
|
|
cmd.Env = append(os.Environ(),
|
|
"XUI_MAIN_FOLDER="+mainFolder,
|
|
"XUI_SERVICE="+serviceFolder,
|
|
)
|
|
setDetachedProcess(cmd)
|
|
if err := cmd.Start(); err != nil {
|
|
_ = os.Remove(scriptPath)
|
|
return fmt.Errorf("failed to start panel update job: %w", err)
|
|
}
|
|
if err := cmd.Process.Release(); err != nil {
|
|
logger.Warning("failed to release panel update process:", err)
|
|
}
|
|
logger.Infof("started panel update job with pid %d", cmd.Process.Pid)
|
|
return nil
|
|
}
|
|
|
|
func downloadPanelUpdater() (string, error) {
|
|
client := &http.Client{Timeout: 15 * time.Second}
|
|
resp, err := client.Get(panelUpdaterURL)
|
|
if err != nil {
|
|
return "", fmt.Errorf("download panel updater: %w", err)
|
|
}
|
|
defer resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
return "", fmt.Errorf("download panel updater: unexpected HTTP %d", resp.StatusCode)
|
|
}
|
|
|
|
file, err := os.CreateTemp("", "3x-ui-update-*.sh")
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
path := file.Name()
|
|
ok := false
|
|
defer func() {
|
|
_ = file.Close()
|
|
if !ok {
|
|
_ = os.Remove(path)
|
|
}
|
|
}()
|
|
|
|
n, err := io.Copy(file, io.LimitReader(resp.Body, maxPanelUpdaterBytes+1))
|
|
if err != nil {
|
|
return "", fmt.Errorf("write panel updater: %w", err)
|
|
}
|
|
if n > maxPanelUpdaterBytes {
|
|
return "", fmt.Errorf("panel updater exceeds %d bytes", maxPanelUpdaterBytes)
|
|
}
|
|
if err := file.Chmod(0700); err != nil {
|
|
return "", err
|
|
}
|
|
ok = true
|
|
return path, nil
|
|
}
|
|
|
|
func fetchLatestPanelVersion() (string, error) {
|
|
client := &http.Client{Timeout: 10 * time.Second}
|
|
resp, err := client.Get("https://api.github.com/repos/MHSanaei/3x-ui/releases/latest")
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
defer resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
return "", fmt.Errorf("GitHub API returned status %d: %s", resp.StatusCode, resp.Status)
|
|
}
|
|
|
|
var release Release
|
|
if err := json.NewDecoder(resp.Body).Decode(&release); err != nil {
|
|
return "", err
|
|
}
|
|
if release.TagName == "" {
|
|
return "", fmt.Errorf("latest panel release tag is empty")
|
|
}
|
|
return release.TagName, nil
|
|
}
|
|
|
|
func resolveUpdateFolders() (string, string) {
|
|
mainFolder := os.Getenv("XUI_MAIN_FOLDER")
|
|
if mainFolder == "" {
|
|
if exePath, err := os.Executable(); err == nil {
|
|
mainFolder = filepath.Dir(exePath)
|
|
}
|
|
}
|
|
if mainFolder == "" {
|
|
mainFolder = "/usr/local/x-ui"
|
|
}
|
|
|
|
serviceFolder := os.Getenv("XUI_SERVICE")
|
|
if serviceFolder == "" {
|
|
serviceFolder = "/etc/systemd/system"
|
|
}
|
|
return mainFolder, serviceFolder
|
|
}
|
|
|
|
func isNewerVersion(latest string, current string) bool {
|
|
cmp, ok := compareVersionStrings(latest, current)
|
|
if !ok {
|
|
return normalizeVersionTag(latest) != normalizeVersionTag(current)
|
|
}
|
|
return cmp > 0
|
|
}
|
|
|
|
func compareVersionStrings(a string, b string) (int, bool) {
|
|
aParts, okA := parseVersionParts(a)
|
|
bParts, okB := parseVersionParts(b)
|
|
if !okA || !okB {
|
|
return 0, false
|
|
}
|
|
for i := 0; i < len(aParts); i++ {
|
|
if aParts[i] > bParts[i] {
|
|
return 1, true
|
|
}
|
|
if aParts[i] < bParts[i] {
|
|
return -1, true
|
|
}
|
|
}
|
|
return 0, true
|
|
}
|
|
|
|
func parseVersionParts(version string) ([3]int, bool) {
|
|
var result [3]int
|
|
parts := strings.Split(normalizeVersionTag(version), ".")
|
|
if len(parts) != 3 {
|
|
return result, false
|
|
}
|
|
for i, part := range parts {
|
|
n, err := strconv.Atoi(part)
|
|
if err != nil {
|
|
return result, false
|
|
}
|
|
result[i] = n
|
|
}
|
|
return result, true
|
|
}
|
|
|
|
func normalizeVersionTag(version string) string {
|
|
return strings.TrimPrefix(strings.TrimSpace(version), "v")
|
|
}
|
|
|
|
func shellQuote(value string) string {
|
|
return "'" + strings.ReplaceAll(value, "'", "'\\''") + "'"
|
|
}
|