hesoyam/Xray-core
1
0
Fork 0
mirror of https://github.com/XTLS/Xray-core.git synced 2026-07-02 17:58:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: simplify browser dialer and remove added conf tests

Browse Source 
Agent-Logs-Url: https://github.com/XTLS/Xray-core/sessions/3aee4c73-7847-433c-905a-2eafe5b1bfe8

Co-authored-by: RPRX <63339210+RPRX@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-04-26 16:23:37 +00:00
committed by GitHub
parent 1d4250e6f0
commit 5afd664c8b
3 changed files with 50 additions and 198 deletions
Download Patch File Download Diff File Expand all files Collapse all files
infra/conf/transport_browser_dialer_test.go
-63
View File
@@ -1,63 +0,0 @@
package conf_test
import (
"net"
"strings"
"testing"
. "github.com/xtls/xray-core/infra/conf"
)
const testBrowserDialerPath = "/123e4567-e89b-12d3-a456-426614174000"
func TestStreamConfigBuildRejectsBrowserDialerUnsupportedProtocol(t *testing.T) {
network := TransportProtocol("tcp")
config := &StreamConfig{
Network: &network,
SocketSettings: &SocketConfig{
BrowserDialer: "127.0.0.1:18080" + testBrowserDialerPath,
},
}
_, err := config.Build()
if err == nil || !strings.Contains(err.Error(), "sockopt.browserDialer only supports websocket or splithttp") {
t.Fatalf("expected unsupported protocol error, got: %v", err)
}
}
func TestStreamConfigBuildRejectsBrowserDialerWithREALITY(t *testing.T) {
network := TransportProtocol("splithttp")
config := &StreamConfig{
Network: &network,
Security: "reality",
SocketSettings: &SocketConfig{
BrowserDialer: "127.0.0.1:18081" + testBrowserDialerPath,
},
}
_, err := config.Build()
if err == nil || !strings.Contains(err.Error(), "sockopt.browserDialer does not support REALITY") {
t.Fatalf("expected REALITY rejection, got: %v", err)
}
}
func TestStreamConfigBuildFailsOnBrowserDialerAddressConflict(t *testing.T) {
listener, err := net.Listen("tcp", "127.0.0.1:0")
if err != nil {
t.Fatalf("failed to prepare occupied listener: %v", err)
}
defer listener.Close()
network := TransportProtocol("websocket")
config := &StreamConfig{
Network: &network,
SocketSettings: &SocketConfig{
BrowserDialer: listener.Addr().String() + testBrowserDialerPath,
},
}
_, err = config.Build()
if err == nil || !strings.Contains(err.Error(), "Failed to start Browser Dialer listener") {
t.Fatalf("expected address conflict error, got: %v", err)
}
}