From 4636ca26753c279accd3d6dac15b1b78047c6d75 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 26 Apr 2026 16:25:25 +0000 Subject: [PATCH] fix: clean up dialer refactor review issues Agent-Logs-Url: https://github.com/XTLS/Xray-core/sessions/3aee4c73-7847-433c-905a-2eafe5b1bfe8 Co-authored-by: RPRX <63339210+RPRX@users.noreply.github.com> --- transport/internet/browser_dialer/dialer.go | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/transport/internet/browser_dialer/dialer.go b/transport/internet/browser_dialer/dialer.go index d39281f9..2c9adee2 100644 --- a/transport/internet/browser_dialer/dialer.go +++ b/transport/internet/browser_dialer/dialer.go @@ -194,10 +194,11 @@ func getDialerByAddress(addr string) (*dialerInstance, error) { server, found := dialerServers[listenAddr] if !found { - server, err := newDialerServer(listenAddr) - if err != nil { - return nil, err + newServer, serverErr := newDialerServer(listenAddr) + if serverErr != nil { + return nil, serverErr } + server = newServer dialerServers[listenAddr] = server } @@ -317,10 +318,7 @@ func dialTaskWithAddress(addr string, task task) (*websocket.Conn, error) { } dialer, err := getDialerByAddress(addr) if err != nil || dialer == nil { - if addr != "" { - return nil, errors.New("browser dialer is not configured for sockopt.browserDialer: ", addr) - } - return nil, errors.New("browser dialer is not configured; set sockopt.browserDialer") + return nil, errors.New("browser dialer is not configured for sockopt.browserDialer: ", addr) } conns := dialer.conns